keith-turner commented on code in PR #286:
URL: https://github.com/apache/accumulo-testing/pull/286#discussion_r1811028513
##########
src/main/java/org/apache/accumulo/testing/performance/tests/SplitBalancingPT.java:
##########
@@ -61,8 +60,7 @@ public Report runTest(final Environment env) throws Exception
{
client.tableOperations().addSplits(TABLE_NAME, getSplits());
client.instanceOperations().waitForBalance();
- int totalTabletServers =
-
client.instanceOperations().getServers(ServerId.Type.TABLET_SERVER).size();
+ int totalTabletServers =
client.instanceOperations().getTabletServers().size();
Review Comment:
This getTabletServers() method is currenty deprecated in main and using it
here will cause the build to fail. So we should not be going back to the
deprecated code. Not sure why but it seems the gh actions build is using an
older version of accumulo 4.0-snap.
Locally when I do the following the accumulo-testing build will fail.
```
git checkout main
git pull
mvn clean install -PskipQA
cd ../accumulo-testing/
git checkout fixBuild
mvn clean package -DskipTests
```
Will see the following errors.
```
[INFO] --- compiler:3.11.0:compile (default-compile) @ accumulo-testing ---
[INFO] Changes detected - recompiling the module! :source
[INFO] Compiling 207 source files with javac [debug deprecation release 11]
to target/classes
[INFO] -------------------------------------------------------------
[WARNING] COMPILATION WARNING :
[INFO] -------------------------------------------------------------
[WARNING]
accumulo-testing/src/main/java/org/apache/accumulo/testing/randomwalk/bulk/SelectiveQueueing.java:[40,50]
getTabletServers() in org.apache.accumulo.core.client.admin.InstanceOperations
has been deprecated
[WARNING]accumulo-testing/src/main/java/org/apache/accumulo/testing/performance/tests/SplitBalancingPT.java:[63,57]
getTabletServers() in org.apache.accumulo.core.client.admin.InstanceOperations
has been deprecated
[INFO] 2 warnings
[INFO] -------------------------------------------------------------
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR]
accumulo-testing/src/main/java/org/apache/accumulo/testing/randomwalk/bulk/SelectiveQueueing.java:
warnings found and -Werror specified
[INFO] 1 error
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
