DomGarguilo commented on PR #4796: URL: https://github.com/apache/accumulo/pull/4796#issuecomment-2283934477
This looks good to me so far. I have two suggestions: 1. Would it be beneficial to include both a `startNew(Duration duration)` method and a `startNew(long duration, TimeUnit units)` method? 2. Would it be useful to add a method that simply returns a boolean indicating whether the countdown timer has finished? This would allow us to check if the timer is done without needing to know the exact time remaining. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
