cshannon commented on PR #4254: URL: https://github.com/apache/accumulo/pull/4254#issuecomment-1954167089
@keith-turner - After I fixed the issue with the column `USER_COMPACTION_REQUESTED` not being read by the scanner inside `TabletManagementIterator` I realized that the `ensureFetched()` check didn't throw an exception like I would have expected and I didn't know why because I looked and there are already unit tests I added that show that check does work and throws an exception if missing. So I investigated and it is because the column was added to the fetchedCols inside TabletManagement by adding it to the `CONFIGURED_COLUMNS` set [here](https://github.com/apache/accumulo/pull/4254/files#diff-a5e21c00133e7d52c9de49a1a42583ac55f7257daab36825638ed4dbbf0d9acbR48). That meant that when the [getUserCompactionsRequested()](https://github.com/apache/accumulo/pull/4254/files#diff-f7cd33f7e1f9321ed285551c95577effc1f35880f80dcaa6e1c74d1ccae8987eR412) was called it didn't throw an illegal state exception since the column was added to the fetched set. However, we it still didn't work until the actual column was [added](https://github.com/apache/accumulo/pull/4254/files#diff-1adf517589f978e7f9cae95a7fdb404a52db469edf102500c3e2885ea7c0eb77R141) to the scanner in my latest commit. I'm thinking there must be a better way to handle that or I missed something because the state check is saying that it was fetched but it wasn't with how it's set up so wondering if there is a better way to do this so it would fail if the scanner is missing the column. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
