ddanielr commented on PR #4223: URL: https://github.com/apache/accumulo/pull/4223#issuecomment-1944110104
Talked with @EdColeman about this PR. The two main concerns: 1. If the job min and max wait properties were changing the thrift communication call. This is not the case as the RetryableThriftCall class uses these options to configure a Retry object. https://github.com/apache/accumulo/blob/f28b55dc254051fea8a3666628fee9868f800a5d/server/base/src/main/java/org/apache/accumulo/server/compaction/RetryableThriftCall.java#L72-L83 The underlying thrift call is not using these properties and remains unaffected. 2. Not setting `maxRetries` would leave the compactor in a state where it appeared hung unless a logging level of `trace` was used. Attempted to correctly calculate the `maxRetries` period and pass that value. Found that the calculation is prone to errors. Opened #4261 to handle that issue separately. Upon further review, the RetryableThriftCall has logging logic that would display log messages of warn during this infinite wait state. This meets the expectation that the user can determine that the compactor is not hung and is looking for work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
