ddanielr commented on code in PR #48: URL: https://github.com/apache/accumulo-access/pull/48#discussion_r1488160538
########## contrib/.gitignore: ########## @@ -31,3 +30,17 @@ /antlr4/nb-configuration.xml /antlr4/.vscode/ /antlr4/.factorypath +/getting-started/target/ Review Comment: > I don't know if `target/` will get the subdirectories, or if it needs to be something like `**/target/`. `target/` will get the subdirectories. I just tested that by removing the `contrib/.gitignore` file and running `mvn clean package` in `accumulo-access/contrib/antlr4`. The `accumulo-access/contrib/antlr4/target` directory showed up under untracked files. I then modified the entry in the `accumulo-access/.gitignore` from `/target/` to `target/` and my `accumulo-access/contrib/antlr4/target` directory and contents were successfully ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
