On Tue, Aug 02, 2016 at 02:01:08AM +0530, Atul Anand wrote: > src: Fixes in nm-device.c and nm-vpn-connection.c to update PacRunner > at the right place and moment. When a device goes up PacRunner is > configured with the Device IPxConfigs and Proxy Config. When it goes > down the same configuration is removed from PacRunner. > > ifcfg-rh: Fixed to read and write proxy settings to the ifcfg network > scripts.
[...]
> @@ -3145,6 +3153,7 @@ nm_device_generate_connection (NMDevice *self, NMDevice
> *master)
> NMSetting *s_con;
> NMSetting *s_ip4;
> NMSetting *s_ip6;
> + NMSetting *s_proxy;
> gs_free char *uuid = NULL;
> const char *ip4_method, *ip6_method;
> GError *error = NULL;
> @@ -3196,6 +3205,9 @@ nm_device_generate_connection (NMDevice *self, NMDevice
> *master)
> s_ip6 = nm_ip6_config_create_setting (priv->ip6_config);
> nm_connection_add_setting (connection, s_ip6);
>
> + s_proxy = nm_proxy_config_create_setting (priv->proxy_config);
nm_proxy_config_create_setting() has this assertion:
g_return_val_if_fail (config != NULL, NULL);
but priv->proxy_config can be NULL here. Probably the function should
handle NULL configurations gracefully, as:
s_proxy = NM_SETTING_PROXY (nm_setting_proxy_new ());
if (!config)
return (NMSetting *) s_proxy;
Beniamino
signature.asc
Description: PGP signature
_______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
