On Wed, 2009-01-07 at 22:05 -0500, Chuck Anderson wrote: > On Wed, Jan 07, 2009 at 09:32:29PM -0500, Chuck Anderson wrote: > > So perhaps we should just NULL out tmp each time before we call > > get_one_ip4_addr. I'll work up a patch. > > I built and tested tested this patch against > NetworkManager-0.7.0-1.git20090102.fc10 and it fixes the problem for > me. > > The patch also initializes netmask to zero before calling > get_one_ip4_addr in that case, even though it isn't strictly necessary > since there is no other call to get_one_ip4_addr with the netmask > variable yet. However, if in the future another call was added, one > would need to make sure to reinitialize netmask to zero before making > the call. It is just safer to never assume and always initialize in > case someone comes along later and copies/pastes the call. > > get_one_ip4_addr is only used within > system-settings/plugins/ifcfg-rh/reader.c AFAICT, so there should be > no other lingering instances of this particular bug.
Committed, thanks! Will get cherry-picked to 0.7 stable too. dan _______________________________________________ NetworkManager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
