Re: [PATCH net-next 8/8] net/mlx5e: Support offload cls_flower with sskbedit mark action

[Amir Vadai]

On Tue, Mar 01, 2016 at 03:58:10PM +0100, Jiri Pirko wrote:
> Tue, Mar 01, 2016 at 03:24:50PM CET, a...@vadai.me wrote:
> >Introduce offloading of skbedit mark action.
> >
> >For example, to mark with 0x1234, all TCP (ip_proto 6) packets arriving
> >to interface ens9:
> >
> > # tc qdisc add dev ens9 ingress
> > # tc filter add dev ens9 protocol ip parent ffff: \
> >     flower ip_proto 6 \
> >     indev ens9 \
> >     action skbedit mark 0x1234
> >
> 
> <snip>
> 
> >@@ -287,6 +288,21 @@ static int parse_tc_actions(struct mlx5e_priv *priv, 
> >struct tcf_exts *exts,
> >                     continue;
> >             }
> > 
> >+            if (is_tcf_skbedit_mark(a)) {
> >+                    u32 mark = tcf_skbedit_mark(a);
> >+
> >+                    if (mark & ~MLX5E_TC_FLOW_ID_MASK) {
> >+                            netdev_warn(priv->netdev,
> >+                                        "Bad flow mark - only 16 bit is 
> >supported: 0x%x\n",
> 
> You can start printk string on the first line.
ack