From: Zhang Shengju <zhangshen...@cmss.chinamobile.com> Date: Mon, 29 Feb 2016 12:22:53 +0000
> If skb_reorder_vlan_header() failed, skb is freed and NULL is returned. > Then at skb_vlan_untag(), it will free skbuff again which cause double > free. The 'skb' local variable in this case will be set to "NULL", calling kfree_skb() on NULL doesn't do anything. > This patch removes kfree_skb() call in function skb_reorder_vlan_header(). > > Signed-off-by: Zhang Shengju <zhangshen...@cmss.chinamobile.com> Please analyze the complete control path of the caller of this function, and you'll find that everything is fine.