On Sun, 28 Feb 2016, Amitoj Kaur Chawla wrote:
On Sun, Feb 28, 2016 at 12:18 AM, Stafford Horne <sho...@gmail.com> wrote: > > > On Thu, 25 Feb 2016, David Miller wrote: > >> From: Amitoj Kaur Chawla <amitoj1...@gmail.com> >> Date: Wed, 24 Feb 2016 19:28:19 +0530 >> >>> Convert a call to init_timer and accompanying intializations of >>> the timer's data and function fields to a call to setup_timer. >>> >>> The Coccinelle semantic patch that fixes this problem is >>> as follows: >>> >>> // <smpl> >>> @@ >>> expression t,f,d; >>> @@ >>> >>> -init_timer(&t); >>> +setup_timer(&t,f,d); >>> ... >>> -t.data = d; >>> -t.function = f; >>> // </smpl> >>> >>> Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> >> >> >> Applied. > > > Hi David, Amitoj, > > The patch here seemed to remove the call to add_timer(&vp->timer) which > applies the expires time. Would that be an issue? > > -Stafford I'm sorry. This is my mistake. How can I rectify it now that the patch is applied? Should I send a patch adding it back?
I sent a patch just now which could help to restore the behavior. This is applied on top of your patch which I pulled from Dave's tree here: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git -Stafford
