On 16-02-24 01:29 AM, Jiri Benc wrote: > On Wed, 24 Feb 2016 00:55:55 -0800, John Fastabend wrote: >> The flags however likely stays with with TCA_U32_FLAGS until there is >> some better way to group common attributes in 'tc' framework. > > That's pretty bad, as this is uAPI and will need to be supported > forever. And having a different attribute in every filter won't ease > things for user space tools. I'd say we need the "better way" to be > added before this patchset. > > Jiri >
The 'tc' semantics seem to support this "pretty bad" API design with many of the fields already duplicated. I suppose we could put the flags at the same level as the TCA_* attributes but this also doesn't seem right to me as it isn't actually handled until we get into the TCA_#CLASSIFIER#_* set of attributes. .John
