On Thu, Feb 18, 2016 at 4:44 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: > On Thu, Feb 18, 2016 at 4:39 PM, Mahesh Bandewar <mahe...@google.com> wrote: >> [snip] >>>> - skb_dst_drop(skb); >>>> + skb_scrub_packet(skb, true); >>> >>> At least this patch is still same with the previous version. Or am I >>> missing anything? >> >> xnet param is now set to 'true'. > > Oh, I was suggesting to set xnet based on the netns of both ipvlan > device and physical device, not setting it to be true or false > unconditionally. > Well, thought about that but don't know any use case / user who is using the ipvlan slave devices in the same ns as master hence decided to do it this way.
> Something like: > > xnet = !netns_eq(dev_net(ipvlan_dev), dev_net(phy_dev)); > > (not real code, just to show my idea) > > Makes any sense? Sure, it's not hard just did for the said reasons.
