From: Jay Vosburgh <[email protected]> Date: Thu, 18 Feb 2016 12:25:52 -0800
> David Miller <[email protected]> wrote: > [...] >>> This was done historically in bonding, but the call to >>> bond_update_speed_duplex was removed in commit 876254ae2758 ("bonding: >>> don't call update_speed_duplex() under spinlocks"), as it might sleep >>> under lock. Later, the locking was changed to only hold RTNL, and so >>> after commit 876254ae2758 ("bonding: don't call update_speed_duplex() >>> under spinlocks") this call is again safe. >>> >>> Tested-by: "Tantilov, Emil S" <[email protected]> >>> Cc: Veaceslav Falico <[email protected]> >>> Cc: dingtianhong <[email protected]> >>> Fixes: 876254ae2758 ("bonding: don't call update_speed_duplex() under >>> spinlocks") >>> Signed-off-by: Jay Vosburgh <[email protected]> >> >>Applied, thanks Jay. > > Rereading the above, I just noticed that I put the wrong commit > into the fixes tag (and the "Later, the locking was changed" text); the > correct fixes tag should be: > > Fixes: 4cb4f97b7e36 ("bonding: rebuild the lock use for bond_mii_monitor()") > > Kernels between 876254ae2758 and 4cb4f97b7e36 should not have > this patch applied, as it might sleep under lock. > > Sorry for the error, Ok, thanks for the info.
