Re: [PATCH net-next 2/2] phy: marvell: Add support for phy packet generator

[Lino Sanfilippo]

Hi,

On 17.02.2016 21:32, Andrew Lunn wrote:
> +
> +     oldpage = phy_read(phydev, MII_MARVELL_PHY_PAGE);
> +     if (oldpage < 0) {
> +             err = oldpage;
> +             goto out;
> +     }
> +

shouldn't this return immediately? Jump to out label and writing an
error value to the phy does not seem to be correct.

Regards,
Lino