> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, February 16, 2016 3:44 PM > To: and...@lunn.ch > Cc: Bryan Whitehead - C21958; f.faine...@gmail.com; netdev@vger.kernel.org > Subject: Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver > > From: Andrew Lunn <and...@lunn.ch> > Date: Tue, 16 Feb 2016 21:36:25 +0100 > > > So this is the discussion we need to have. > > > > The interface to the outside work is the two switch ports with real > > PHYs. What you are implementing is an Ethernet driver for an internal > > port connected to the switch. This port does not go to the outside > > world. This driver provides no way to control the ports to the outside > > world and you have no short term plan to actually implement control of > > the ports connected to the outside world. > > > > Should the Linux community accept this driver in this state? > > > > I would prefer to see a simple switchdev or DSA driver which exposes > > the two external ports. > > I do not think, with all the infrastructure we have, that we should accept > pure > ethernet drivers for such devices any more. > > About year ago I would have responded differently, but these days all of the > necessary support and infrastructure is there, and reasonable easy for driver > authors to use.
I believe I can make the physical phys accessible through ethertool. Would that be reasonable? Bryan
