Aaron F <[email protected]> wrote:
From: Intel-wired-lan [[email protected]] on behalf of Stefan Assmann [[email protected]]Sent: Wednesday, February 03, 2016 12:20 AM To: [email protected] Cc: [email protected]; [email protected]; [email protected]Subject: [Intel-wired-lan] [PATCH net-next V2 4/6] igb: call ndo_stop() instead of dev_close() when running offline selftestCalling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <[email protected]> --- drivers/net/ethernet/intel/igb/igb.h | 2 ++ drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++-- drivers/net/ethernet/intel/igb/igb_main.c | 8 ++++---- 3 files changed, 8 insertions(+), 6 deletions(-)Checkpatch warns that externs should be avoided in .c files, but they pre-existed and are just being flagged due to the name changing, so...Tested-by: Aaron Brown <[email protected]>
Again, the prototypes in the .c should be deleted in favor of the ones that were added to the .h file.
-- Mark Rustad, Networking Division, Intel Corporation
signature.asc
Description: Message signed with OpenPGP using GPGMail
