Hi Florian, On Mon, Feb 15, 2016 at 10:22:14AM -0800, Florian Fainelli wrote: > > > On 15/02/2016 10:19, Florian Fainelli wrote: > > On 15/02/2016 09:52, Clemens Gruber wrote: > >> For the Marvell 88E1510, marvell_of_reg_init was called too late (in > >> m88e1510_config_aneg), which lead to the phy state machine being stuck > >> at waiting for interrupts, which are off by default on the 88E1510. > >> This further lead to the ethernet link not coming up at boot. > >> For some Marvell PHYs, marvell_of_reg_init was not called at all. > > > > You could mention that this became apparent with > > ... > 113c74d83eef ("net: phy: turn carrier off on phy attach")
Thanks for your comments. I thought it would be better to just leave all PHYs with special requirements (resets, ..) as they were and only change the behavior of those who were missing the marvell_of_reg_init calls. What do you think? Clemens