From: Francois Romieu
> Sent: 06 February 2016 10:59
> > +void mpls_stats_inc_outucastpkts(struct net_device *dev,
> > +                            const struct sk_buff *skb)
> > +{
> > +   struct mpls_dev *mdev;
> > +   struct inet6_dev *in6dev;
> 
> Nit: the scope can be reduced for both variables.

And hiding the definitions of variables in the middle of
functions just makes them harder to find.       

        David

Reply via email to