Re: [PATCH v2 net-next 4/4] net: fib: avoid calling fib_flush for each device when doing batch close and unregister

[Salam Noureddine]

On Fri, Feb 5, 2016 at 8:04 AM, Sergei Shtylyov
<sergei.shtyl...@cogentembedded.com> wrote:
> On 02/05/2016 02:35 AM, Salam Noureddine wrote:

>>
>>         if (event == NETDEV_UNREGISTER) {
>> -               fib_disable_ip(dev, event, true);
>> +               if (fib_sync_down_dev(dev, event, true))
>> +                       net->ipv4.needs_fib_flush = true;
>>                 rt_flush_dev(dev);
>>                 return NOTIFY_DONE;
>>         }
>>
>> +       if (event == NETDEV_UNREGISTER_BATCH || event ==
>> NETDEV_DOWN_BATCH) {
>> +               if (net->ipv4.needs_fib_flush) {
>> +                       fib_flush(net);
>> +                       net->ipv4.needs_fib_flush = false;
>> +               }
>> +               rt_cache_flush(net);
>> +               arp_ifdown_all();
>> +               return NOTIFY_DONE;
>> +       }
>> +
>
>
>    I'd convert to *switch* the above 2 *if*'s...
>
> [...]
>
> MBR, Sergei
>

I could do that.

Thanks,

Salam