On 16-02-01 02:43 AM, Amir Vadai wrote: > On Mon, Feb 01, 2016 at 01:31:17AM -0800, John Fastabend wrote: >> On 16-02-01 12:34 AM, Amir Vadai wrote: >>> During initialization, tcf_exts_offload_init() is called to initialize >>> the list of actions description. later on, the classifier description >>> is prepared and sent to the switchdev using switchdev_port_flow_add(). >>> >>> When offloaded, fl_classify() is a NOP - already done in hardware. >>> >>> Signed-off-by: Amir Vadai <a...@vadai.me> >>> --- >> >> You need to account for where the classifier is being loaded >> by passing the handle as I did in my patch set. Otherwise you may >> be offloading on egress/ingress or even some qdisc multiple layers >> down in the hierarchy. > Right. Will fix it.
also it seems you missed fl_delete() this will be called from cmds like 'tc filter delete ...' > >> >> .John >>
