Hi Sudip, On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: > On error we jumped to the error label and returned the error code but we > missed releasing sinfo. > > Signed-off-by: Sudip Mukherjee <su...@vectorindia.org>
Should the From: and Signed-off-by: email addresses be the same? > --- > net/mac80211/sta_info.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c > index 6c198e6..36e75c4 100644 > --- a/net/mac80211/sta_info.c > +++ b/net/mac80211/sta_info.c > @@ -561,6 +561,7 @@ static int sta_info_insert_finish(struct sta_info *sta) > __acquires(RCU) > __cleanup_single_sta(sta); > out_err: > mutex_unlock(&local->sta_mtx); > + kfree(sinfo); > rcu_read_lock(); > return err; > } Looks sane to me. I must note that the bug this is fixing is only in the mac80211-next tree. Fixes: 5fe74014172d ("mac80211: avoid excessive stack usage in sta_info") Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/