On Fri, Jan 29, 2016 at 2:01 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Fri, 2016-01-29 at 13:41 -0800, Cong Wang wrote: >> On Thu, Jan 28, 2016 at 5:43 PM, <roy.qing...@gmail.com> wrote: >> > From: Li RongQing <roy.qing...@gmail.com> >> > >> > The size of all_zeros_mac is 6 byte, but eth_hash() will access the >> > 8 byte, and KASan reported the below bug: >> >> >> Sounds like we should fix eth_hash() (macvlan has a same function), >> it should not read beyond 6 bytes. > > Why ? We always have at least 2 bytes following ethernet address in a > packet.
Because we have to fix all the cases that don't. > > Better add these 2 bytes in all_zeros_mac[] and not slow down the hash > function. > > We use same tricks in eth_type_trans() > I never doubt it works, as long as you want to audit all the cases like this one, sure go for it.
