Florian,

> Looks fine, just one nit below:
> 
> > @@ -954,6 +956,7 @@ static int lan78xx_link_reset(struct lan78xx_net
> *dev)
> >
> >             ret = lan78xx_update_flowcontrol(dev, ecmd.duplex, ladv,
> radv);
> >             netif_carrier_on(dev->net);
> 
> Do you need this netif_carrier_on() call here? PHYLIB should set that
> already.
> 
> > +           phy_mac_interrupt(phydev, 1);
> >     }

Thanks for feedback.
As you pointed, netif_carrier_on() is redundant and also netif_carrier_off() in 
same routine.
Will post new patch.

Thanks,
Woojung

Reply via email to