Re: [PATCH v2] can: c_can: add xceiver enable/disable support

[Bjørn Mork]

Michael Grzeschik <m.grzesc...@pengutronix.de> writes:

> @@ -1263,6 +1271,10 @@ int register_c_can_dev(struct net_device *dev)
>        */
>       pinctrl_pm_select_sleep_state(dev->dev.parent);
>  
> +     priv->reg_xceiver = devm_regulator_get(priv->device, "xceiver");
> +     if (IS_ERR(priv->reg_xceiver))
> +             return PTR_ERR(priv->reg_xceiver);
> +
>       c_can_pm_runtime_enable(priv);
>  
>       dev->flags |= IFF_ECHO; /* we support local echo */

Do you really want to leave priv->reg_xceiver pointing to an ERR_PTR in
case of error?



Bjørn