From: Yuchung Cheng <[email protected]>
Date: Wed, 6 Jan 2016 12:42:38 -0800
> Patch 3759824da87b ("tcp: PRR uses CRB mode by default and SS mode
> conditionally") introduced a bug that cwnd may become 0 when both
> inflight and sndcnt are 0 (cwnd = inflight + sndcnt). This may lead
> to a div-by-zero if the connection starts another cwnd reduction
> phase by setting tp->prior_cwnd to the current cwnd (0) in
> tcp_init_cwnd_reduction().
>
> To prevent this we skip PRR operation when nothing is acked or
> sacked. Then cwnd must be positive in all cases as long as ssthresh
> is positive:
>
> 1) The proportional reduction mode
> inflight > ssthresh > 0
>
> 2) The reduction bound mode
> a) inflight == ssthresh > 0
>
> b) inflight < ssthresh
> sndcnt > 0 since newly_acked_sacked > 0 and inflight < ssthresh
>
> Therefore in all cases inflight and sndcnt can not both be 0.
> We check invalid tp->prior_cwnd to avoid potential div0 bugs.
>
> In reality this bug is triggered only with a sequence of less common
> events. For example, the connection is terminating an ECN-triggered
> cwnd reduction with an inflight 0, then it receives reordered/old
> ACKs or DSACKs from prior transmission (which acks nothing). Or the
> connection is in fast recovery stage that marks everything lost,
> but fails to retransmit due to local issues, then receives data
> packets from other end which acks nothing.
>
> Fixes: 3759824da87b ("tcp: PRR uses CRB mode by default and SS mode
> conditionally")
> Reported-by: Oleksandr Natalenko <[email protected]>
> Signed-off-by: Yuchung Cheng <[email protected]>
> Signed-off-by: Neal Cardwell <[email protected]>
> Signed-off-by: Eric Dumazet <[email protected]>
Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
