Emil S <emil.s.tanti...@intel.com> wrote: >> */ >> - if (hw->mac.type == ixgbe_mac_X540) >> + if ((hw->mac.type == ixgbe_mac_X540) && >> + (netdev->flags & IFF_SLAVE)) >> if (link_speed == IXGBE_LINK_SPEED_UNKNOWN) >> return; > > If you were to enter ixgbe_watchdog_link_is_up() with unknown speed, then I > would > assume that you also have a dmesg that shows: > "NIC Link is Up unknown speed" > > by the interface you use in the bond?
It seems odd to be checking the MAC type for this. Is this behavior perhaps more related to the copper phy? If so, then the check should be changed. Or would the check for unknown link speed be sufficient? It seems like an interface as a slave would not work with an unknown link speed, so it may as well wait in all cases, not just for X540. -- Mark Rustad, Networking Division, Intel Corporation
signature.asc
Description: Message signed with OpenPGP using GPGMail
