On Sun, Dec 20, 2015 at 11:46:30PM +0200, Saeed Mahameed wrote:
> +/* Should run once every mlx5e_tstamp->overflow_period */
> +static void mlx5e_timestamp_overflow(struct work_struct *work)
> +{
> + struct delayed_work *dwork = to_delayed_work(work);
> + struct mlx5e_tstamp *tstamp = container_of(dwork, struct mlx5e_tstamp,
> overflow_work);
> + unsigned long flags;
> +
> + write_lock_irqsave(&tstamp->lock, flags);
> + timecounter_read(&tstamp->clock);
> + if (tstamp->overflow_period)
> + schedule_delayed_work(&tstamp->overflow_work,
> tstamp->overflow_period);
You don't need this test, and the call to schedule_delayed_work can be
outside of the lock.
> + write_unlock_irqrestore(&tstamp->lock, flags);
> +}
> +void mlx5e_timestamp_cleanup(struct mlx5e_priv *priv)
> +{
> + struct mlx5e_tstamp *tstamp = &priv->tstamp;
> +
> + if (!MLX5_CAP_GEN(priv->mdev, device_frequency_khz))
> + return;
> +
> + write_lock(&tstamp->lock);
> + tstamp->overflow_period = 0; /* Signal overflow_check to stop */
> + write_unlock(&tstamp->lock);
This is unnecessary because
> +
> + cancel_delayed_work_sync(&tstamp->overflow_work);
this will block until the work is cancelled.
> +}
Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
