From: Herbert Xu <[email protected]> Date: Wed, 16 Dec 2015 18:13:14 +0800
> William Hua <[email protected]> wrote: >> >> I wasn't aware there was an enforced minimum size. I simply set the >> nelem_hint in the rhastable_params struct to 1, expecting it to grow as >> needed. This caused a segfault afterwards when trying to insert an >> element. > > OK we're doing the size computation before we enforce the limit > on min_size. > > ---8<--- > We need to do the initial hash table size computation after we > have obtained the correct min_size/max_size parameters. Otherwise > we may end up with a hash table whose size is outside the allowed > envelope. > > Fixes: a998f712f77e ("rhashtable: Round up/down min/max_size to...") > Reported-by: William Hua <[email protected]> > Signed-off-by: Herbert Xu <[email protected]> Applied and queued up for -stable, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
