On Tue, 15 Dec 2015 16:48:25 +0100, Paolo Abeni wrote: > This patch add support for IFLA_VXLAN_COLLECT_METADATA via the > 'collectmetadata' keyword to the vxlan link.
Could we give this more understandable name? I've never liked the COLLECT_METADATA name as it describes the actual implementation, not the intention of the flag. The name should express that the vxlan interface is driven by an external control plane instead of the internal fdb. This could be ovs, a route, tc action, etc. Something like "external" would be better name, I think. Also, as a related remark, please note that IFLA_VXLAN_COLLECT_METADATA is mutually exclusive with many other flags. It's currently not enforced correctly at the kernel level (instead, you get weird behavior). I'll fix this on the kernel side but we may want to enforce this on the iproute2 side, too, to get a better error message. This is not to be addressed by this patch, though. Jiri -- Jiri Benc -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
