On 14.12.2015 18:50, Eric Dumazet wrote: > On Mon, 2015-12-14 at 18:27 +0100, Hannes Frederic Sowa wrote: > >> Otherwise I would recommend adding a "!!" to express that we actually >> want bound set based on the portid value? > > Note that compiler already does the !! thing, when you store an integer > into a bool var.
Exactly, the gcc compiler does that automatically when writing to a _Bool type. > So it definitely is a matter of taste and code readability. Yes, as I wrote, this patch doesn't alter the any runtime behavior, it confused me and thus I wanted to make the assignment more explicit. It looked like a trap to me, thus I wanted to change it. Bye, Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
