On Tue, Dec 08, 2015 at 10:15:08AM -0800, Florian Fainelli wrote:
> On 07/12/15 09:38, Russell King wrote:
> > Add an I2C MDIO bus bridge library, to allow phylib to access PHYs which
> > are connected to an I2C bus instead of the more conventional MDIO bus.
> > Such PHYs can be found in SFP adapters and SFF modules.
> >
> > Signed-off-by: Russell King <rmk+ker...@arm.linux.org.uk>
> > ---
> [snip]
> > +static int i2c_mii_read(struct mii_bus *bus, int phy_id, int reg)
> > +{
> > + struct i2c_adapter *i2c = bus->priv;
> > + struct i2c_msg msgs[2];
> > + u8 data[2], dev_addr = reg;
> > + int bus_addr, ret;
> > +
> > + bus_addr = 0x40 + phy_id;
> > + if (bus_addr == 0x50 || bus_addr == 0x51)
> > + return 0xffff;
>
> These could deserve a local definition for these specific addresses so
> we know why there is such logic here.
This is the only comment I've received on this series so far; I'm
waiting for further comments before addressing it.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
