On Wed, 9 Dec 2015 11:45:57 +0100 Tilman Schmidt <til...@imap.cc> wrote:
> Am 08.12.2015 um 23:16 schrieb One Thousand Gnomes: > > The right fix as far as I can see is to remove the tests although > > WARN_ON() combined with your tty->ops change might be safer. > > Feel free to submit a patch. Will do later today. Want a patch on top of Paul's change or a single patch including both and crediting him ? > > tty locking reviews, but drivers/isdn and net/irda weren't traditionally > > part of the general tty maintenance but handled separately/ > > Or just ignored. Unfortunately at the time that seemed to happen a lot. > >> test puzzle me. It's not obvious why they're needed. Ie, can the null > >> dereferences they try to catch really happen? But I can try to figure > >> out that in the future, if I ever feel the urge to do so. Anyhow: > >> > >> Acked-by: Paul Bolle <pebo...@tiscali.nl> > > > > Nacked-by: Alan Cox <a...@linux.intel.com> > > So you feel it's better to maintain the current inconsistent state > created by commit f34d7a5b? Please elaborate. No I'd rather we didn't make it look magically better then forget about the mess in question. Alan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
