On Thu, 2015-12-03 at 15:43 -0200, Marcelo Ricardo Leitner wrote:
> Vlad, others,
>
> It's been a long time but this was introduced by commit 914e1c8b6980
> ("sctp: Inherit all socket options from parent correctly."). This is not
> very consistent with how other protocols work and it will be hard to
> keep tracking a negative mask of flags that we can't copy.
>
> I reviewed the list of options and I'm thinking that only
> SO_BINDTODEVICE is worth copying, leaving the others for the application
> to re-set, as it is for other protocols. So I'm thinking on simply:
>
> - newsk->sk_flags = sk->sk_flags;
> + newsk->sk_flags = sk->sk_flags & SO_BINDTODEVICE;
>
> in the above.
>
> What do you think?
I think SO_BINDTODEVICE is not a flag ;)
#define SO_BINDTODEVICE 25
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
