From: Hannes Frederic Sowa <han...@stressinduktion.org> Date: Tue, 01 Dec 2015 16:41:48 +0100
> On Tue, Dec 1, 2015, at 14:19, Paolo Abeni wrote: >> Currently all the vport_ops list manipulation functions are protected by >> the ovs_lock (even the lookup): the scenario described above should not >> be possible. > > This makes all sense and it seems no use-after-free is possible at all > (I didn't notice the lookup path takes the lock). But the macro still > looks ugly and modifies a global struct with a per-module linked symbol. > David, why exactly didn't you like the first patch? Seems to me it does > what is actually needed. Because it is error prone. I want it hidden quietly and reliably in a macro, just like we do for other similar cases across the tree. The caller of the registry functions has no reason to be concerned with these details if we can take care of it transparently. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html