On Tue, Nov 17, 2015 at 05:56:56AM -0800, Eric Dumazet wrote: > skb->sender_cpu and skb->napi_id share a common storage, > and we had various bugs about this. > > We had to call skb_sender_cpu_clear() in some places to > not leave a prior skb->napi_id and fool netdev_pick_tx() > > As suggested by Alexei, we could split the space so that > these errors can not happen. > > 0 value being reserved as the common (not initialized) value, > let's reserve [1 .. NR_CPUS] range for valid sender_cpu, > and [NR_CPUS+1 .. ~0U] for valid napi_id.
nice. that's a cleaner and simpler range split. > This will allow proper busy polling support over tunnels. > > Signed-off-by: Eric Dumazet <[email protected]> > Suggested-by: Alexei Starovoitov <[email protected]> Acked-by: Alexei Starovoitov <[email protected]> Great series of patches! Looking forward to try them out on rpc workloads. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
