On Tue, 2015-11-17 at 15:55 +0100, Hannes Frederic Sowa wrote: > I want to move to unix_state_lock and completely drop sk_buff_head.lock > in af_unix, as such I would prefer to keep it this way as in some other > places in af_unix.c (e.g. unix_stream_connect). > > Or do you have a strong opinion on that?
I am saying we use 2 times skb_queue_tail(), one time skb_unlink(), and 2 times skb_queue_purge(), all using spin_lock_irqsave() But you took the single __skb_queue_tail() that was present in this file ;) No strong opinion, just a matter of simplicity and code size. Reported-by: Eric Dumazet <eduma...@google.com> Acked-by: Eric Dumazet <eduma...@google.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
