Arthur Marsh wrote on 14/11/15 13:46:
Hi, I'm not sure if this is an actual error or just an informational message but on this pc (with a single-core AMD Athlon(tm) 64 Processor 3200+) I've been getting the following: Nov 13 18:16:12 localhost kernel: [ 0.938025] via-rhine 0000:00:12.0 eth0: set_features() failed (-1); wanted 0x0000000000004000, left 0x0000000000004800 Nov 13 18:16:12 localhost kernel: [ 0.938574] via-rhine 0000:00:12.0 eth0: VIA Rhine II at 0x1e000, 00:13:d4:cc:9b:57, IRQ 23 Nov 13 18:16:12 localhost kernel: [ 0.939418] via-rhine 0000:00:12.0 eth0: MII PHY found at address 1, status 0x786d advertising 01e1 Link 45e1 The Ethernet card still works nonetheless. git-bisect showed that the: eth0: set_features() failed (-1); wanted 0x0000000000004000, left 0x0000000000004800 messages started with the following commit: git bisect good e7868a85e1b26bcb2e71088841eec1d310a97ac9 is the first bad commit commit e7868a85e1b26bcb2e71088841eec1d310a97ac9 Author: Jarod Wilson <ja...@redhat.com> Date: Tue Nov 3 23:09:32 2015 -0500 net/core: ensure features get disabled on new lower devs With moving netdev_sync_lower_features() after the .ndo_set_features calls, I neglected to verify that devices added *after* a flag had been disabled on an upper device were properly added with that flag disabled as well. This currently happens, because we exit __netdev_update_features() when we see dev->features == features for the upper dev. We can retain the optimization of leaving without calling .ndo_set_features with a bit of tweaking and a goto here.
Nikolay Aleksandrov's patch: http://patchwork.ozlabs.org/patch/544307/ fixed the issue for me thanks. Arthur. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html