David Miller wrote:
> From: Eric Dumazet <[email protected]>
> Date: Sat, 07 Nov 2015 10:50:07 -0800
>
> > I do not feel we should go back to kmalloc() just because
> > vmalloc_array() does not exist yet.
>
> Agreed.
>
Please change as you like.
I was thinking to introduce a helper that does vmalloc() when
kmalloc() failed because locations that do
ptr = kmalloc(size, GFP_NOFS);
if (!ptr)
ptr = vmalloc(size); /* Wrong because GFP_KERNEL is used implicitly */
are found. I just noticed that inet_ehash_locks_alloc() is doing
ptr = kmalloc_array(count, size, GFP_KERNEL);
if (!ptr)
ptr = vmalloc(count * size); /* Wrong because overflow is not checked */
and wanted to know your intent.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
