On Thu, 2015-11-05 at 11:07 -0800, Eric Dumazet wrote:
> From: Eric Dumazet <eduma...@google.com>
>
> For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix
> ireq->pktopts race"), we need to make sure we do not access
> req->saved_syn unless we own the request sock.
>
> This fixes races for listeners using TCP_SAVE_SYN option.
> *own_req = inet_ehash_nolisten(newsk, req_to_sk(req_unhash));
> + if (*own_req)
> + tcp_move_syn(newtp, req_unhash);
>
> return newsk;
Humpff, req_unhash needs to be 'req', otherwise we will crash for FAST
OPEN connections (for which req_unhash == NULL)
I will send a fix, sorry for this David :(
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
