On Wed, 2015-11-04 at 22:59 +0200, Julian Anastasov wrote:
>
> Patches 1 and 3 look correct to me,
>
> Reviewed-by: Julian Anastasov <[email protected]>
Thanks for checking!
> If the patches are lost in the merge window you
> can also consider one minor optimization, see below...
Oh, yeah, they probably are - sorry Dave.
> > - } else if (rt->rt_type == RTN_BROADCAST)
> > + } else if (rt->rt_type == RTN_BROADCAST) {
> > IP_UPD_PO_STATS_BH(net, IPSTATS_MIB_INBCAST, skb-
> >len);
> > + } else {
>
> } else if (unlikely(skb->pkt_type != PACKET_HOST)) {
>
> May be such check can save some cycles because
> it is more common to see PACKET_HOST packets...
I had thought about that based on your earlier comments, but then I
didn't quite see the point. However, perhaps we could invert the check
below to check the pkt_type first, hoping it'll have some kind of cache
effect?
johannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
