roopa <ro...@cumulusnetworks.com> writes: > On 11/1/15, 1:27 PM, Eric W. Biederman wrote: >> Roopa Prabhu <ro...@cumulusnetworks.com> writes: >> >>> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c >>> index c70d750..7db9678 100644 >>> --- a/net/mpls/af_mpls.c >>> +++ b/net/mpls/af_mpls.c >>> @@ -27,6 +27,8 @@ >>> */ >>> #define MAX_MP_SELECT_LABELS 4 >>> >>> +u32 mpls_multipath_secret __read_mostly; >> This mpls_multipath_secret is never used. >> > It is used in mpls_multipath_rebalance, same as fib_rebalance.
fib_multipath_secret is only initialized in fib_rebalalance. fib_multipath_secret is used used in fib_multipath_hash, which is called in fib_select_path. The equivalent code does not exist in your mpls patch. Eric -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
