From: Wengang Wang <wen.gang.w...@oracle.com> Date: Fri, 25 Sep 2015 09:52:40 +0800
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c > index 5f4a556..c0534c2 100644 > --- a/net/ipv4/route.c > +++ b/net/ipv4/route.c > @@ -2097,7 +2097,10 @@ struct rtable *__ip_route_output_key(struct net *net, > struct flowi4 *fl4) > */ > > fl4->flowi4_oif = dev_out->ifindex; > - goto make_route; > + if (dev_out->flags & IFF_LOOPBACK) > + goto make_route; > + else > + goto lookup; > } This is still broken. By definition invoking fib_lookup() and depending upon it finding something in this path is going to break things for somebody, somewhere. Before your change, if we lacked a multicast route, the user would still get a functioning path. Furthermore, most of the other "goto make_route" cases in this function suffer from the same exact problem you're trying to solve. Therefore, special casing one instance makes no sense at all. I want you to, instead of making potentially lethal semantic changes here, fix the real problem instead. That is, I want you to fix how we do not cache routes we create merely because we lack a fib_info. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
