On Fri, Oct 30, 2015 at 8:12 PM, Sowmini Varadhan <sowmini.varad...@oracle.com> wrote: > On (10/30/15 20:06), Andy Shevchenko wrote: >> >> > +#include "i40e.h" >> >> Why do you need this one exactly? > > I needed it to find pf->pdev below. > >> > + struct device_node *dp = pci_device_to_OF_node(pf->pdev); > > Without it, you will get: > : > CC [M] drivers/net/ethernet/intel/i40e/i40e_common.o > drivers/net/ethernet/intel/i40e/i40e_common.c: In function > ?i40e_get_platform_mac_addr?: > drivers/net/ethernet/intel/i40e/i40e_common.c:1021: error: dereferencing > pointer to incomplete type
OK > Unless you feel passionately about the \n nits, I'm going to pass on those. > Thanks for reviewing. I'm okay, whatever maintainer now accepts. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
