On Wed, Oct 28, 2015 at 03:12:57PM +0100, Neil Armstrong wrote:
> Some switch drivers might request interrupts, remap register ranges,
> allow such drivers to implement a "remove" callback doing just that.
>
> Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com>
> ---
> include/net/dsa.h | 1 +
> net/dsa/dsa.c | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/include/net/dsa.h b/include/net/dsa.h
> index 98ccbde..0e1502c 100644
> --- a/include/net/dsa.h
> +++ b/include/net/dsa.h
> @@ -212,6 +212,7 @@ struct dsa_switch_driver {
> */
> char *(*probe)(struct device *host_dev, int sw_addr);
> int (*setup)(struct dsa_switch *ds);
> + void (*remove)(struct dsa_switch *ds);
> int (*set_addr)(struct dsa_switch *ds, u8 *addr);
> u32 (*get_phy_flags)(struct dsa_switch *ds, int port);
>
> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
> index 1eba07f..f462fc5 100644
> --- a/net/dsa/dsa.c
> +++ b/net/dsa/dsa.c
> @@ -459,6 +459,10 @@ static void dsa_switch_destroy(struct dsa_switch *ds)
> }
>
> mdiobus_unregister(ds->slave_mii_bus);
> +
> + /* Leave a chance to the driver to cleanup */
A nitpick:
/* Give the driver a chance to cleanup */
would be better English.
Reviewed-by: Andrew Lunn <and...@lunn.ch>
Andrew
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
