On Sat, Oct 17, 2015 at 12:21:44AM -0400, Michael Chan wrote: > Broadcom ethernet driver for the new family of NetXtreme-C/E > ethernet devices. > > v3: > - Fixed 2 more sparse warnings. > - Removed some unused structures in .h files. > > v2: > - Fixed all kbuild test robot reported warnings. > - Fixed many of the checkpatch.pl errors and warnings. > - Fixed the Kconfig description. > > Acked-by: Eddie Wai <eddie....@broadcom.com> > Acked-by: Jeffrey Huang <huan...@broadcom.com> > Signed-off-by: Prashant Sreedharan <prash...@broadcom.com> > Signed-off-by: Michael Chan <mc...@broadcom.com> > --- > drivers/net/ethernet/broadcom/Kconfig | 19 + > drivers/net/ethernet/broadcom/Makefile | 1 + > drivers/net/ethernet/broadcom/bnxt/Makefile | 4 + > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5821 > ++++++++++++++++++++ > drivers/net/ethernet/broadcom/bnxt/bnxt.h | 994 ++++ > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1150 ++++ > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h | 18 + > drivers/net/ethernet/broadcom/bnxt/bnxt_fw_hdr.h | 104 + > drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 4046 ++++++++++++++ > drivers/net/ethernet/broadcom/bnxt/bnxt_nvm_defs.h | 59 + > drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 787 +++ > drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h | 22 + > 12 files changed, 13025 insertions(+) > create mode 100644 drivers/net/ethernet/broadcom/bnxt/Makefile > create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt.c > create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt.h > create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c > create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h > create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_fw_hdr.h > create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h > create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_nvm_defs.h > create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c > create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h
Well, it's a big one! But overall I'd say it looks pretty good... I agree with Stephen's style comments, and there are a couple of strings that are crazy long -- not just a source readability problem, but things that would be hard to digest in a log as well. If you address those then I'll be happy to ACK it. John -- John W. Linville Someday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
