On 10/20/2015 10:38 AM, Hannes Frederic Sowa wrote: > MSG_MORE might cause the packet to get fragmented in the end when > passed down to the flush function and the transhdrlen check alone is > not sufficient to protect against fragmentation. Instead check if the > socket user intends to add more data to the socket on the first packet. > > This broke checksum calculation for UDPv6 for NFS protocols. > > Fixes: 32dce968dd987 ("ipv6: Allow for partial checksums on non-ufo packets") > Cc: Vlad Yasevich <vyasev...@gmail.com>
Acked-by: Vlad Yasevich <vyasev...@gmail.com> -vlad > Tested-by: Sabrina Dubroca <s...@quesysnail.net> > Tested-by: Benjamin Coddington <bcodd...@redhat.com> > Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> > --- > net/ipv6/ip6_output.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c > index 61d403e..95c5780 100644 > --- a/net/ipv6/ip6_output.c > +++ b/net/ipv6/ip6_output.c > @@ -1317,6 +1317,7 @@ emsgsize: > * sums only work when transhdrlen is set. > */ > if (transhdrlen && sk->sk_protocol == IPPROTO_UDP && > + !(flags & MSG_MORE) && > length + fragheaderlen < mtu && > rt->dst.dev->features & NETIF_F_V6_CSUM && > !exthdrlen) > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html