On Thu, 2015-10-15 at 12:26 -0400, Insu Yun wrote: > Since vzalloc can be failed in memory pressure, > return value should be checked and return ENOMEM. > > Signed-off-by: Insu Yun <wuni...@gmail.com> > --- > drivers/net/xen-netback/xenbus.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen > -netback/xenbus.c > index 929a6e7..e288246 100644 > --- a/drivers/net/xen-netback/xenbus.c > +++ b/drivers/net/xen-netback/xenbus.c > @@ -788,6 +788,11 @@ static void connect(struct backend_info *be) > /* Use the number of queues requested by the frontend */ > be->vif->queues = vzalloc(requested_num_queues * > sizeof(struct xenvif_queue)); > + if (!be->vif->queues) { > + xenbus_dev_fatal(dev, -ENOMEM, "allocating queues"); > + return; > + }
Please fix the coding style, perhaps using checkpatch.pl or by observing the surrounding code. Ian. > + > be->vif->num_queues = requested_num_queues; > be->vif->stalled_queues = requested_num_queues; > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html