On Thu, 24 Sep 2015 20:25:01 -0700 Scott Feldman <sfel...@gmail.com> wrote:
> On Thu, Sep 24, 2015 at 2:05 PM, Stephen Hemminger > <step...@networkplumber.org> wrote: > > On Thu, 24 Sep 2015 13:59:26 -0700 > > sfel...@gmail.com wrote: > > > >> From: Scott Feldman <sfel...@gmail.com> > >> > >> Push bridge-level attributes down to switchdev drivers. This patchset > >> adds the infrastructure and then pushes, as an example, ageing_time > >> attribute > >> down from bridge to switchdev (rocker) driver. Add some range-checking > >> for ageing_time. > >> > >> # ip link set dev br0 type bridge ageing_time 1000 > >> > >> # ip link set dev br0 type bridge ageing_time 999 > >> RTNETLINK answers: Numerical result out of range > >> > >> Up until now, switchdev attrs where port-level attrs, so the netdev used in > >> switchdev_attr_set() would be a switch port or bond of switch ports. With > >> bridge-level attrs, the netdev passed to switchdev_attr_set() is the bridge > >> netdev. The same recusive algo is used to visit the leaves of the stacked > >> drivers to set the attr, it's just in this case we start one layer higher > >> in > >> the stack. One note is not all ports in the bridge may support setting a > >> bridge-level attribute, so rather than failing the entire set, we'll skip > >> over > >> those ports returning -EOPNOTSUPP. > > > > > > Rather than having more in bridge, shouldn't this just be a netlink event? > > You lost me? Oh, do you mean netdev notifier? Jiri (privately) had > suggested that also. Yes. I meant a netlink notifier so that user or kernel space driver can track changes. Otherwise you have to add switchdev callbacks for each parameter. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
