From: Neil Horman <nhor...@redhat.com> Date: Tue, 22 Sep 2015 16:01:36 -0400
> - set_bit(NAPI_STATE_NPSVC, &napi->state); > + /* > + * If we set this bit but see that it has already been set, > + * that indicates that napi has been disabled and we need > + * to abort this operation > + */ > + > + if(test_and_set_bit(NAPI_STATE_NPSVC, &napi->state)) > + goto out; > Networking comments should be styled: /* Like * this. */ Also you need a space after the "if" and before the openning parenthesis. And like Stephen I think the empty line between the comment and the if() statement is superfluous and eats up precious vertical space on the screen :-) Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html