ip_route_input_slow is a maze of gotos (9 of them!) making it error
prone and difficult to read. This patchset refactors it, removing all
but 2 of the labels. The brd_input label for broadcast path requires
too many inputs to make a reasonble helper out of it so I left it as is.
None of these patches change functionality, only move code around
to make ip_route_input_slow more readable.
Size comparison using gcc version 4.7.2 (Debian 4.7.2-5)
With CONFIG_IP_ROUTE_VERBOSE:
Before patches:
$ size kbuild2/net/ipv4/route.o
text data bss dec hex filename
20615 2321 32 22968 59b8 kbuild2/net/ipv4/route.o
After patches:
$ size kbuild/net/ipv4/route.o
text data bss dec hex filename
20711 2321 32 23064 5a18 kbuild/net/ipv4/route.o
An increase of 96 bytes with CONFIG_IP_ROUTE_VERBOSE.
Without CONFIG_IP_ROUTE_VERBOSE:
Before patches:
$ size kbuild2/net/ipv4/route.o
text data bss dec hex filename
19778 2321 32 22131 5673 kbuild2/net/ipv4/route.o
After patches:
$ size kbuild/net/ipv4/route.o
text data bss dec hex filename
19847 2321 32 22200 56b8 kbuild/net/ipv4/route.o
An increase of 69 bytes without CONFIG_IP_ROUTE_VERBOSE.
v2
- Addressed comments from Eric B and Alex Duyck
David Ahern (9):
net: Remove martian_source_keep_err goto label
net: Remove e_inval label from ip_route_input_slow
net: Remove e_nobufs label from ip_route_input_slow
net: Move rth handling from ip_route_input_slow to helper
net: Move martian_destination to helper
net: Remove martian_source goto
net: Remove martian_destination label
net: Remove local_input label
net: Remove no_route label
net/ipv4/route.c | 233 +++++++++++++++++++++++++++++++------------------------
1 file changed, 133 insertions(+), 100 deletions(-)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
